Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workbox-webpack-plugin + workbox-precaching #794

Closed
madmoizo opened this issue Sep 11, 2017 · 4 comments
Closed

workbox-webpack-plugin + workbox-precaching #794

madmoizo opened this issue Sep 11, 2017 · 4 comments

Comments

@madmoizo
Copy link

madmoizo commented Sep 11, 2017

Library Affected:
workbox-build

Feature Request Description:
workbox-webpack-plugin compatible with workbox-precaching.

Currently, because of injection process (searching for .precache) https://github.com/GoogleChrome/workbox/blob/master/packages/workbox-build/src/lib/inject-manifest.js#L57 you have to use workbox-sw (47kb) even if you just need the workbox-precaching lib (22kb)

@prateekbh
Copy link
Collaborator

@gauntface it'd be great if we can split this up.
SwPrecacheWebpackPlugin already does this

@gauntface
Copy link

We will hopefully have a much nicer story for in you V3.

If webpack could generate just the manifest file, you'd be able to import that in and use just the workbox-precaching module.

cc @goldhand just as an FYI. @jeffposnick is starting to work on the workbox-build v3 stuff, so hopefully we can start enabling the next webpack version and take advantage of some of the V3 plans soon.

@gauntface gauntface added this to the V3 milestone Sep 15, 2017
@goldhand
Copy link
Collaborator

Webpack can generate the manifest file! I have that working and meant to jump on the wednesday convo to chat a little. I've been out of the loop for a little but hoping to get caught up with the plans soon!

That said, not sure exactly what the context of this issue is.

@jeffposnick
Copy link
Contributor

I believe that #933 tracks this in a more general form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants