Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(flakiness): limit max builds to 100 #4818

Merged

Conversation

aslushnikov
Copy link
Contributor

This was missing in #4808

Copy link
Contributor

@JoelEinbinder JoelEinbinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? I’m missing context.

@aslushnikov
Copy link
Contributor Author

That's a good practice to limit storage. 100 is the number of builds used in Chromium Flakiness Dashboard.

@aslushnikov aslushnikov merged commit 608b15f into puppeteer:master Aug 8, 2019
@aslushnikov aslushnikov deleted the flaky-limit-max-builds-to-100 branch August 8, 2019 22:15
rfojtik pushed a commit to rfojtik/puppeteer that referenced this pull request Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants