chore(flakiness): update flakiness format #4808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch: - updates Flakiness Dashboard format to define version per-build and to pass COMMIT information - drops the README.md generation - we'll move on to a designated flakiness dashboard viewer
|
NOTE: Prior to landing this commit, I'll migrate all the current flakiness data to the format. Edit: data updated in flakiness repo. |
aslushnikov
added a commit
to aslushnikov/puppeteer-flakiness-dashboard
that referenced
this pull request
Aug 6, 2019
Migrate to puppeteer/puppeteer#4808
aslushnikov
added a commit
to aslushnikov/puppeteer-flakiness-dashboard
that referenced
this pull request
Aug 6, 2019
Migrate to puppeteer/puppeteer#4808
aslushnikov
added a commit
to aslushnikov/puppeteer-flakiness-dashboard
that referenced
this pull request
Aug 6, 2019
Migrate to puppeteer/puppeteer#4808
aslushnikov
added a commit
to aslushnikov/puppeteer-flakiness-dashboard
that referenced
this pull request
Aug 6, 2019
Migrate to puppeteer/puppeteer#4808
aslushnikov
added a commit
to aslushnikov/puppeteer-flakiness-dashboard
that referenced
this pull request
Aug 6, 2019
Migrate to puppeteer/puppeteer#4808
aslushnikov
added a commit
to aslushnikov/puppeteer-flakiness-dashboard
that referenced
this pull request
Aug 6, 2019
Migrate to puppeteer/puppeteer#4808
aslushnikov
added a commit
to aslushnikov/puppeteer-flakiness-dashboard
that referenced
this pull request
Aug 6, 2019
Migrate to puppeteer/puppeteer#4808
aslushnikov
added a commit
to aslushnikov/puppeteer-flakiness-dashboard
that referenced
this pull request
Aug 6, 2019
Migrate to puppeteer/puppeteer#4808
| @@ -111,6 +111,8 @@ new Reporter(testRunner, { | |||
| showSlowTests: process.env.CI ? 5 : 0, | |||
| }); | |||
|
|
|||
| utils.initializeFlakinessDashboardIfNeeded(testRunner); | |||
| testRunner.run(); | |||
| (async() => { | |||
There was a problem hiding this comment.
nit: can you move this to the top of this file, like line 20. Its easier to reason about this file if the whole thing is async, rather than just one step at the end.
There was a problem hiding this comment.
I tried that initially, but didn't like extra indentation. Does this bother you strongly?
| commit: { | ||
| sha, | ||
| timestamp, | ||
| url: `https://github.com/GoogleChrome/puppeteer/commit/${sha}`, |
There was a problem hiding this comment.
is baking in the repo URL necessary here? The commit hash should be enough.
There was a problem hiding this comment.
Don't want to rely on Github URL schemes too much in flakiness viewer. This comes for free since this is per-build only (and there are not many builds)
There was a problem hiding this comment.
What happens if we ever move the repo?
JoelEinbinder
approved these changes
Aug 6, 2019
|
I think it bothers me more than the indentation bothers you, but I don’t
feel super strongly about it.
…On Tue, Aug 6, 2019 at 3:25 PM Andrey Lushnikov ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In test/test.js
<#4808 (comment)>
:
> @@ -111,6 +111,8 @@ new Reporter(testRunner, {
showSlowTests: process.env.CI ? 5 : 0,
});
-utils.initializeFlakinessDashboardIfNeeded(testRunner);
-testRunner.run();
+(async() => {
I tried that initially, but didn't like extra indentation. Does this
bother you strongly?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#4808>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABDI62JTHHQJYXYXKGD6PTLQDH27HANCNFSM4IJP335Q>
.
|
|
I'll land this now and will discuss the reason for your disturbance offline |
This was referenced Dec 4, 2019
rfojtik
pushed a commit
to rfojtik/puppeteer
that referenced
this pull request
Dec 21, 2019
This patch: - updates Flakiness Dashboard format to define version per-build and to pass COMMIT information - drops the README.md generation - we'll move on to a designated flakiness dashboard viewer
rfojtik
pushed a commit
to rfojtik/puppeteer
that referenced
this pull request
Dec 21, 2019
This was missing in puppeteer#4808
This was referenced Feb 3, 2020
This was referenced Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
and to pass COMMIT information
dashboard viewer