-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@import inline broken in version 2.0.3+ #198
Comments
@marrone Thanks for bringing this into our attention. Will try to recreate it locally first then fix it ASAP in 2.0.5. |
@marrone it's indeed a bit hard to replicate it so would it be possible for you to mail your CSS files at dev (at) goalsmashers.com? We'd track down the issue, create a simple test case, and delete your files afterwards. |
I believe I stumbled upon the same problem. I could break down the problem to the following situation.
Now, |
@janraasch that's it! Thanks for coming up with the test case. Fix should be there soon. |
@janraasch Just noticed the error does not go away with |
I noticed the bug I was describing with the update of |
@janraasch grunt-contrib-cssmin was also where I encountered the issue. For me the error was introduced with 2.0.3 of clean-css. When you force the dependency of 2.0.2, it works. I am using all default options, so perhaps those defaults changed for clean-css which may be a difference in the result as well, I dont know yet @GoalSmashers I will try to provide a simple test case |
@marrone Great, looking forward to it! |
@marrone @janraasch If you have a moment and opportunity please check 904145b as it's a potential fix to this issue. |
@marrone @janraasch clean-css 2.0.6 is out with the fix, so please verify if it works for you and feel free to reopen this issue if needed. |
Works fine for me. Thanks for the fix. |
Sure, anytime 👍 |
Commit 7b739b6 seems to have broken @imports between version 2.0.2 and 2.0.3
In our main.css file, we have something like
In 2.0.2, the imports were merged inline and minified without issue. In 2.0.3, only the first @import is merged, and the following @imports are not, instead the final @import appears broken inline, the above example outputs
I tried creating a simple test case, but it appears to depend partially on the contents of the imported stylesheets (I suspect a greedy regex), so I do not yet have a simple repeatable example for you
The text was updated successfully, but these errors were encountered: