Allow keepSpecialComments to be set as a string #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it helps then why not having it. We'll push 1.1.5 with this change soon. Thanks @shama! |
GoalSmashers
pushed a commit
that referenced
this pull request
Oct 24, 2013
Allow keepSpecialComments value of 0 and 1 to be set as a string.
|
Thank you! |
|
1.1.5 is out - enjoy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On grunt-contrib-cssmin, some users are setting
keepSpecialCommentsas a string instead of a number. This causesundefinedto be prepended to their file. See gruntjs/grunt-contrib-cssmin#40This would make setting that option with
'1'or'0'work the same as a number directly. Hopefully this will prevent the error from their common mistake.Thanks!