Media Query issue

[lukeapage]

Hi,

I'm part of the less core team. We always had an option to compress with yui-compressor, but due to lack of support for that we are looking at moving to a different npm package.

We had a bug raised about the existing compressor which is what brought this about. However testing with clean css has produced some strange results (I think). Apologies if there is a reason for this.

With this input from less

@media print, (-o-min-device-pixel-ratio: 5/4), (-webkit-min-device-pixel-ratio: 1.25), (min-resolution: 120dpi) {
  /* Style adjustments for high resolution devices */
}
/**===================================================**\
/**  PRINT STYLES
/**===================================================**/
@media only print {
  a,
  a:visited {
    text-decoration: underline;
  }
  a[href]:after {
    content: " (" attr(href) ")";
  }
  abbr[title]:after {
    content: " (" attr(title) ")";
  }
  /** MANUALLY TRUNCATED FOR BREVITY **/
}

we get

@media print,(-o-min-device-pixel-ratio:5/4),(-webkit-min-device-pixel-ratio:1.25),(min-resolution:120dpi){}/ @media only print{a,a:visited{text-decoration:underline}a[href]:after{content:" (" attr(href) ")"}abbr[title]:after{content:" (" attr(title) ")"}}

1. what is the / about? It seems to be caused by using \ instead of / at the end of the comment.. it seems to be making clean-css get confused
2. could you save space by removing empty media blocks?

[GoalSmashers]

Hi @lukeapage,

1. It's indeed suspicious and probably a bug in clean-css comment stripping code. We will issue a fix later today.
2. We should do it as well (as we have cleaning up empty selectors now) - I'll open a new bug regarding this shortly.

Thanks for raising both issues,
Jakub @ GoalSmashers.com

[GoalSmashers]

@lukeapage clean-css 1.0.11 is out with the fix due to wrong optimizations ordering. As it turns out the 2nd issue you experienced was due to a fact that clean-css removes empty selectors only if asked to (as that's an expensive optimization). Just use -e or removeEmpty: true when calling from command line or JavaScript respectively.

[XhmikosR]

@GoalSmashers: Isn't this issue fixed then?

[GoalSmashers]

It is, good catch!