From bdb5f3d87133139d798d62702b059939524e83e6 Mon Sep 17 00:00:00 2001 From: John Ralls Date: Mon, 27 Sep 2021 15:35:35 -0700 Subject: [PATCH] Revert "[gnc-plugin-page-register] when reversing reversed txn, offer jump" This reverts commit b8c9b1a6ce0e1e4c6740e1de450859b90cbadcec so that we can release 4.8 without any translatable string changes. --- gnucash/gnome/gnc-plugin-page-register.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/gnucash/gnome/gnc-plugin-page-register.c b/gnucash/gnome/gnc-plugin-page-register.c index 989593cef63..ff7ade8d494 100644 --- a/gnucash/gnome/gnc-plugin-page-register.c +++ b/gnucash/gnome/gnc-plugin-page-register.c @@ -4072,6 +4072,13 @@ gnc_plugin_page_register_cmd_reverse_transaction (GtkAction* action, if (trans == NULL) return; + if (xaccTransGetReversedBy (trans)) + { + gnc_error_dialog (GTK_WINDOW (window), "%s", + _ ("A reversing entry has already been created for this transaction.")); + return; + } + split = gnc_split_register_get_current_split (reg); account = xaccSplitGetAccount (split); @@ -4081,17 +4088,6 @@ gnc_plugin_page_register_cmd_reverse_transaction (GtkAction* action, return; } - new_trans = xaccTransGetReversedBy (trans); - if (new_trans) - { - const char *rev = _("A reversing entry has already been created for this transaction."); - const char *jump = _("Jump to the transaction?"); - if (gnc_verify_dialog (GTK_WINDOW (window), TRUE, "%s\n\n%s", rev, jump)) - goto jump_to_trans; - else - return; - } - if (!gnc_dup_time64_dialog (window, _("Reverse Transaction"), _("New Transaction Information"), &date)) { @@ -4108,7 +4104,6 @@ gnc_plugin_page_register_cmd_reverse_transaction (GtkAction* action, gnc_resume_gui_refresh(); - jump_to_trans: /* Now jump to new trans */ gsr = gnc_plugin_page_register_get_gsr (GNC_PLUGIN_PAGE (page)); split = xaccTransFindSplitByAccount(new_trans, account);