Skip to content
This repository was archived by the owner on Jan 15, 2021. It is now read-only.

[Listing] Display "friendly name" for response status codes #23

Closed
lostintangent opened this issue Sep 15, 2016 · 16 comments
Closed

[Listing] Display "friendly name" for response status codes #23

lostintangent opened this issue Sep 15, 2016 · 16 comments

Comments

@lostintangent
Copy link

lostintangent commented Sep 15, 2016

Most web devs probably know what a 200, 404, 500 etc. are, but the distinction between a 301 and 304 can be subtle for folks, and so displaying the "friendly name" in addition to just the actual status code can be pretty helpful (e.g. Moved Permanently vs. Not Modified).

This is definitely a nice-to-have, but it was something we did in the F12 network tool based on feedback, and we found it to be a simple improvement, somewhat similarly to how the Glimpse client displays a "friendly name" for well known middleware.

chromestatus

@nikmd23
Copy link
Member

nikmd23 commented Sep 21, 2016

@chetsangnil, this is great feedback from @lostintangent and I agree with his suggestion.

Could you take a look at the list of status codes and their descriptions and figure out how we'd add this to the UI? A word of warning, some of the descriptions can get a little long, like 431 - Request Header Fields Too Large, so we'll want to make sure to account for those cases, as well as the short ones like 200 - OK.

@chetsangnil
Copy link

Looking into it now, no problem!

@nikmd23
Copy link
Member

nikmd23 commented Sep 22, 2016

Hey @chetsangnil. I see this is marked as In Review now, would you mind posting the changes your proposing here?

@chetsangnil
Copy link

chetsangnil commented Sep 22, 2016

There you go! Nothing on the right panel got changed. I added the describtion of the status code right next to the Status number in the request panel.

status-code-name_v1

@nikmd23 nikmd23 added this to the M013 milestone Sep 23, 2016
@nikmd23
Copy link
Member

nikmd23 commented Sep 26, 2016

I'll set up a call to discuss this. Much easier to be on the phone for design stuff.

@nikmd23 nikmd23 self-assigned this Sep 26, 2016
@chetsangnil
Copy link

Updated mock: element that got changed are in the red box

status-code-name_v2

@chetsangnil
Copy link

chetsangnil commented Sep 27, 2016

Here're 3 different variation for this issue:

V1.
image

V.2
image

V.3
image

My vote would be V.2 because it allows viewers to easily scan for various different content (Method, Status, and url) since they line up very nicely. For V1 and V3, I had difficult time scanning for content that matter to me but they maybe a more common way to display these kind of contents? What do you think?

@lostintangent
Copy link
Author

I would also vote for v2

@nikmd23
Copy link
Member

nikmd23 commented Sep 27, 2016

I voted for an edited version of V2. 😉

@chetsangnil will add another option soon.

@chetsangnil
Copy link

3 more edited versions!

V2.1
image

V2.2
image

V2.3
image

Let me know what you think! I do have the one i prefer in mind but I wonder if you would pick to same one ;)

@lostintangent
Copy link
Author

I like v2.3 :)

@nikmd23
Copy link
Member

nikmd23 commented Sep 27, 2016

Yeah, I think 2.3 is the winner as well. Let's go with it. I liked the idea of having the status icons aligned, but the spacing ends up looking a bit off.

I'm going to move this to devs to implement.

Note to the developers. OK is the standard message for a 200 and File Not Found is the standard message for 404, but they don't have to be. We should be sure to respect the response.statusMessage property.

@nikmd23 nikmd23 assigned avanderhoorn and unassigned nikmd23 and chetsangnil Sep 27, 2016
@chetsangnil
Copy link

chetsangnil commented Sep 27, 2016

YES! I prefer v2.3 as well! Perfect, please move this into the development. Thanks guys for all the input, this is great :D

@chetsangnil
Copy link

chetsangnil commented Sep 27, 2016

Here's the clean up version of 2.3 (grouping request a little bit better) ready for development.

Full mock:
image

Element that got effected:
image

@avanderhoorn : Let me know when you need those status icon, I can send them over to you.

@avanderhoorn avanderhoorn modified the milestones: Backlog, M013 Oct 7, 2016
@nikmd23 nikmd23 modified the milestones: M016, Backlog Nov 18, 2016
@avanderhoorn avanderhoorn changed the title [Feature Request] Display "friendly name" for response status codes [Listing] Display "friendly name" for response status codes Nov 23, 2016
@nikmd23
Copy link
Member

nikmd23 commented Jan 4, 2017

👍

@nikmd23
Copy link
Member

nikmd23 commented Jan 7, 2017

This is now available in Glimpse for Node 0.16.4. Please see our announcement issue for more information.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants