Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local branch merges bypass the direct push mechanism #5

Open
GitHooksIO opened this issue Feb 22, 2016 · 0 comments
Open

Local branch merges bypass the direct push mechanism #5

GitHooksIO opened this issue Feb 22, 2016 · 0 comments
Labels

Comments

@GitHooksIO
Copy link
Collaborator

This is an interesting one - do we want developers to be able to work on a new branch locally, merge it with branchToProtect locally, and push it up? Currently, they are able to do so.

Or do we want to force them to open a Pull Request?

I guess it depends on what this GitHook is offering - if it is only to encourage a branching workflow, then what we have is sufficient. If it is to force better visibility of what happens to the branchToProtect, then maybe we want some restrictions in place.

However, thinking ahead to when we implement githook-forced-code-reviews, we would want some way of preventing local merges because otherwise these two GitHooks combined could still be easily bypassed by developers working locally on their branch and merging locally and pushing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant