Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definitively decide between _opt and _exn funcs #144

Open
Tracked by #83
NatKarmios opened this issue Nov 2, 2022 · 0 comments
Open
Tracked by #83

Definitively decide between _opt and _exn funcs #144

NatKarmios opened this issue Nov 2, 2022 · 0 comments
Assignees
Labels

Comments

@NatKarmios
Copy link
Contributor

From #134

We frequently have two functions that do the same thing, but one returns an option, while the other fails where None would be returned.

There are two conventions for naming these:

  • f returns x option, f_exn returns x or fails
  • f returns x or fails, f_opt returns x option

We currently mix these - we should make this consistent.
I think I'd prefer the first approach, but we can have that conversation before implementing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant