QC: replace stop() with rlang::abort() throughout package

[lauramaxwell]

QC Details

use rlang::abort() instead of stop() for fatal errors so that it can provide more information, rather than just the message. See this for more information on the differences

Additional Comments

[jonthegeek]

cli::cli_abort() wraps rlang::abort() but adds nice formatting. I'd definitely recommend going all the way there.

[lauramaxwell]

yeah, i was going off of devin's comment, but sort of think it makes sense to use cli formatting in a log4r fatal log per zelos' work. happy to come up with a solution that makes the most sense here in the comments

[zdz2101]

I believe I wrapped both "ERROR" and "FATAL" in logger as cli::cli_abort() because I couldn't quite figure out the difference between errors and fatal in our gsm package, I can certainly start drafting where to do the proper inserts

[zdz2101]

How do we feel about the:

• stopifnot() messages
• stop_if_empty() is currently a wrapper for only 3 calls inside MakeBounds() ?

Should we create some sort of assert/stop wrapper along the lines of:

stop_if  <- function(condition, message) {
     if(condition) {
     LogMessage(level = "error", message = message)
    }
}

it would collapse these calls and use the log4r setup we have?
@jonthegeek @lauramaxwell @samussiah

[jonthegeek]

stopifnot() is convenient, but it'd be nice for it to hook into logging & cli-style messaging. I definitely support implementing something like this! We could even include stop_if_not() as a convenience wrapper to make conversion easier:

stop_if_not <- function(condition, message) {
  stop_if(!condition, message)
}

[samussiah]

How do we feel about the:

• stopifnot() messages
• stop_if_empty() is currently a wrapper for only 3 calls inside MakeBounds() ?

Should we create some sort of assert/stop wrapper along the lines of:

stop_if  <- function(condition, message) {
     if(condition) {
     LogMessage(level = "error", message = message)
    }
}

it would collapse these calls and use the log4r setup we have? @jonthegeek @lauramaxwell @samussiah

Love it.