Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: strOutpath in Report_KRI() #1755

Closed
jonthegeek opened this issue Aug 6, 2024 · 1 comment
Closed

Bugfix: strOutpath in Report_KRI() #1755

jonthegeek opened this issue Aug 6, 2024 · 1 comment
Milestone

Comments

@jonthegeek
Copy link
Contributor

Expected Behavior

If I pass a filename or relative path, I expect the report to write to my working directory (or relative to my working directory).

Current Behavior

If you pass something other than an absolute path, it writes to the directory where the template report comes from (inst during dev, the root of the installed package for users). This behavior is inherited from rmarkdown::render().

Possible Solution

Use {rprojroot} to put it relative to the project, or perhaps fs::path_abs() to do it relative to the working directly (not taking a project into account). The here::here() docs recommend NOT using it in functions.

Steps to Reproduce

Context (Environment)

Possible Implementation

Additional Comments

@lauramaxwell
Copy link
Contributor

fixed in #1768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants