Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC: Use gt for Report_MetricTable() #1659

Closed
jonthegeek opened this issue Jul 15, 2024 · 0 comments · Fixed by #1884
Closed

QC: Use gt for Report_MetricTable() #1659

jonthegeek opened this issue Jul 15, 2024 · 0 comments · Fixed by #1884
Assignees
Labels
reporting improvements Reporting functionality

Comments

@jonthegeek
Copy link
Contributor

jonthegeek commented Jul 15, 2024

QC Details

Report_MetricTable() uses kableExtra::kbl(), while Report_FlagOverTime() and Report_StudyInfo() use gt::gt() (via gsm_gt()). Update Report_MetricTable() to match.

Additional Comments

Note: Report_FormatFlag() will have to also be updated to output a format that gt() is compatible with (or potentially we need to do something to tell gt that the column contains SVGs).

@jonthegeek jonthegeek changed the title Feature: Use gt for Report_MetricTable() QC: Use gt for Report_MetricTable() Jul 15, 2024
@lauramaxwell lauramaxwell added the reporting improvements Reporting functionality label Sep 4, 2024
@jwildfire jwildfire added this to the v2.2.0 milestone Oct 9, 2024
@zdz2101 zdz2101 self-assigned this Oct 11, 2024
@lauramaxwell lauramaxwell removed this from the v2.2.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reporting improvements Reporting functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants