Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical bugs #1

Closed
TinoDidriksen opened this issue Jul 16, 2022 · 3 comments
Closed

Critical bugs #1

TinoDidriksen opened this issue Jul 16, 2022 · 3 comments

Comments

@TinoDidriksen
Copy link

If this is what created e.g. https://github.com/giellalt/lang-kal/commits/main_with_history_fixed then there are critical bugs:

  • Commit dates are lost. Looks like all commits are from when the script was run.

  • Commits have the runner as committer (with original committer as author).

  • Authors list is wrong. At least my name is, so probably others are.

@albbas
Copy link
Contributor

albbas commented Jul 18, 2022

If this is what created e.g. https://github.com/giellalt/lang-kal/commits/main_with_history_fixed then there are critical bugs:

Thanks for the feedback!

I used gitk to get an overview of the git log and such. The main history view shows the correct commit dates, so I thought everything was fine and dandy.

first-lang-kal

* Commit dates are lost. Looks like all commits are from when the script was run.

* Commits have the runner as committer (with original committer as author).

Now that you mention it, I see that the committer and author info are different.
author-committer-lang-kal

git filter-branch can be used to set committer name and date equal to the author ditto.

* Authors list is wrong. At least my name is, so probably others are.

I/We can fix the author info in svn2git-authors.txt, turn it into a git mailmap, and use git filter-repo --mailmap my-mailmap to correct the info in the repo.

I'm on vacation now, but can have a look at this when I'm back.

@snomos
Copy link

snomos commented Oct 11, 2022

Commands to clean up history can be found here: giellalt/giella-core#20 (comment)

@albbas
Copy link
Contributor

albbas commented Oct 31, 2022

All the above issues have been solved with the commits pushed today

@albbas albbas closed this as completed Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants