Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Autocomplete): fix for bug when clicking another instance #1722

Merged
merged 2 commits into from
Sep 26, 2019

Conversation

benjamincharity
Copy link
Contributor

Fix for bug that is still lingering when clicking from one autocomplete directly to another.

Leveraged fix from the new selection list component

@benjamincharity benjamincharity changed the title WIP: possible fix [ci skip] fix(Autocomplete): fix for bug when clicking another instance Sep 26, 2019
@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #1722 into release will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           release    #1722      +/-   ##
===========================================
- Coverage    96.07%   96.05%   -0.03%     
===========================================
  Files          131      131              
  Lines         5227     5216      -11     
  Branches       893      889       -4     
===========================================
- Hits          5022     5010      -12     
- Misses         200      206       +6     
+ Partials         5        0       -5
Impacted Files Coverage Δ
...tocomplete-panel/autocomplete-trigger.directive.ts 87.08% <ø> (-0.97%) ⬇️
terminus-ui/select/src/select.component.ts 73.42% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1094125...67f9fef. Read the comment docs.

@benjamincharity benjamincharity merged commit b36c77a into release Sep 26, 2019
@benjamincharity benjamincharity deleted the autocomplete-panel-bug-v2 branch September 26, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants