Navigation items in drop down respect external links #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, navigation items displayed by a `ts-navigation` component will properly handle external links by using hrefs for them rather than router links.
coreyterminator
requested review from
atlwendy,
benjamincharity and
shani-terminus
as code owners
benjamincharity
approved these changes
Sep 9, 2019
atlwendy
approved these changes
Sep 9, 2019
Codecov Report
@@ Coverage Diff @@
## release #1686 +/- ##
========================================
Coverage 95.53% 95.53%
========================================
Files 128 128
Lines 4858 4858
Branches 812 845 +33
========================================
Hits 4641 4641
Misses 217 217Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, navigation items displayed by a
ts-navigationcomponent will properly handle external links by using hrefs for them rather than router links.