chore(SCSS): created skeleton for testing SCSS

[shani-terminus]

ISSUES CLOSED: #952

[shani-terminus]

"testMatch" is the only change in the jest.config. the rest is conversion of " to '

[codecov]

Codecov Report

Merging #1521 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1521   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files         110      110           
  Lines        3803     3803           
  Branches      490      490           
=======================================
  Hits         3781     3781           
  Misses         22       22

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bafad5e...85f5870. Read the comment docs.

[codecov]

Codecov Report

Merging #1521 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1521   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files         110      110           
  Lines        3803     3803           
  Branches      521      490   -31     
=======================================
  Hits         3781     3781           
  Misses         22       22

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ff01d...17688d3. Read the comment docs.

[benjamincharity]

What is the undefined item we are ignoring?

[shani-terminus]

The True mixins: describe and test. I can probably make two one-liners, but it was useful having the whole doc when in discovery mode.

[benjamincharity]

Hmm I wonder why this is needed but isn't needed in all the other files that use those two..

[benjamincharity]

Alright, figured out why this was happening. Our ESLint configuration sets the jest environment for files ending with spec or mock so it wasn't catching this new file naming convention. We can remove this ESLint comment by extending the overrides section of our ESLint configuration:

.eslintrc.js

module.exports = {
  "extends": ["@terminus/eslint-config-frontend/development"],
  "parserOptions": {
    "ecmaVersion": 6,
    "project": "./tsconfig.json",
    "sourceType": "module"
  },
  "rules": {
    "no-console": [
      "error",
      {
        "allow": [
          "warn"
        ]
      }
    ]
  },
  'overrides': [
    {
      'files': [
        '**/*.spec.ts',
        '**/*.mock.ts',
        '**/test-sass.js',
      ],
      'env': {
        'jest': true,
      },
    },
  ],
}

.eslintrc.ci.js

module.exports = {
  "extends": ["@terminus/eslint-config-frontend"],
  "parserOptions": {
    "ecmaVersion": 6,
    "project": "./tsconfig.json",
    "sourceType": "module"
  },
  "rules": {
    "no-console": [
      "error",
      {
        "allow": [
          "warn"
        ]
      }
    ]
  },
  'overrides': [
    {
      'files': [
        '**/*.spec.ts',
        '**/*.mock.ts',
        '**/test-sass.js',
      ],
      'env': {
        'jest': true,
      },
    },
  ],
}

[benjamincharity]

Let's make the configuration change so we can remove this comment.

[atlwendy]

👍 scss spec is new to me.

[atlwendy]

Is this commented out block for future reference?