Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Spacing): has integration tests #1481

Merged
merged 3 commits into from
Apr 25, 2019
Merged

chore(Spacing): has integration tests #1481

merged 3 commits into from
Apr 25, 2019

Conversation

shani-terminus
Copy link
Contributor

ISSUES CLOSED: #1294

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #1481 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1481   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files         107      107           
  Lines        3756     3756           
  Branches      532      532           
=======================================
  Hits         3736     3736           
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb1590b...0131164. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 23, 2019 •
edited
Loading

Codecov Report

Merging #1481 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1481   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files         107      107           
  Lines        3756     3756           
  Branches      506      532   +26     
=======================================
  Hits         3736     3736           
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d92ef17...145c55d. Read the comment docs.

atlwendy
atlwendy reviewed Apr 24, 2019
View reviewed changes
terminus-ui/spacing/src/vertical-spacing.directive.spec.ts

expect(fixtureBasic).toBeTruthy();
const spacingDiv = fixtureBasic.debugElement.query(By.directive(TsVerticalSpacingDirective));
expect(spacingDiv).toBeTruthy();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this tests spacingDiv existence. but it doesn't test the default value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Wendy. It does not have a class, but I did find another way to check!

benjamincharity
benjamincharity approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@benjamincharity benjamincharity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@benjamincharity benjamincharity merged commit b08f5e8 into master Apr 25, 2019
@benjamincharity benjamincharity deleted the 1294-verticalSpacing-tests branch June 21, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlwendy atlwendy atlwendy left review comments

@benjamincharity benjamincharity benjamincharity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VerticalSpacing: Convert to integration test
3 participants
@shani-terminus @benjamincharity @atlwendy