Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input: Determine why the isFunction method cannot be used from the tools library #1156

Closed
2 tasks
benjamincharity opened this issue Dec 14, 2018 · 0 comments · Fixed by #2007
Closed
2 tasks

Input: Determine why the isFunction method cannot be used from the tools library #1156

benjamincharity opened this issue Dec 14, 2018 · 0 comments · Fixed by #2007
Labels
Focus: component Issues concerning a specific component Needs: exploration Issues that need more information before being worked on Type: chore Something that needs to be done but is not a bug or addition

Comments

@benjamincharity
Copy link
Contributor

Using the function from the ngx-tools library seems to lose typings somehow. Even when using the coercion function, TS doesn't seem to know the item is a function. Defining the function directly did work.

  • Determine the changes needed to make it work with the library import
  • Remove hard-coded function from input
@benjamincharity benjamincharity added Focus: component Issues concerning a specific component Needs: exploration Issues that need more information before being worked on Type: chore Something that needs to be done but is not a bug or addition labels Dec 14, 2018
@benjamincharity benjamincharity mentioned this issue May 7, 2019
Merged
@atlwendy atlwendy mentioned this issue Feb 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Focus: component Issues concerning a specific component Needs: exploration Issues that need more information before being worked on Type: chore Something that needs to be done but is not a bug or addition
Projects
None yet
Milestone
No milestone
1 participant
@benjamincharity