fix(FileUpload): protect against cdr being called after it's destroyed

GetTerminus · Feb 19, 2019 · 0990b38 · 0990b38
1 parent 9ade135
commit 0990b38
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/terminus-ui/file-upload/src/file-upload.component.ts b/terminus-ui/file-upload/src/file-upload.component.ts
@@ -488,7 +488,12 @@ export class TsFileUploadComponent extends TsReactiveFormBaseComponent implement
    */
   public updateInnerValue = (value: string): void => {
     this.value = value;
-    this.changeDetectorRef.detectChanges();
+
+    // NOTE: This `if` is to avoid: `Error: ViewDestroyedError: Attempt to use a destroyed view: detectChanges`
+    // istanbul ignore else
+    if (!this.changeDetectorRef['destroyed']) {
+      this.changeDetectorRef.detectChanges();
+    }
   }
 
 
@@ -501,7 +506,11 @@ export class TsFileUploadComponent extends TsReactiveFormBaseComponent implement
       this.formControl.valueChanges.pipe(
         untilComponentDestroyed(this),
       ).subscribe(() => {
-        this.changeDetectorRef.detectChanges();
+        // NOTE: This `if` is to avoid: `Error: ViewDestroyedError: Attempt to use a destroyed view: detectChanges`
+        // istanbul ignore else
+        if (!this.changeDetectorRef['destroyed']) {
+          this.changeDetectorRef.detectChanges();
+        }
       });
     }
   }