From 09790bfa753d754bad739dbfd06f89ab5ecf7b2c Mon Sep 17 00:00:00 2001 From: Benjamin Charity Date: Wed, 12 Feb 2020 08:16:16 -0500 Subject: [PATCH] fix(Services): define external services as singletons ISSUES CLOSED: #2014 --- terminus-ui/chart/src/amcharts.service.ts | 2 +- terminus-ui/chart/src/chart.component.md | 2 +- terminus-ui/validators/src/validators.service.md | 1 + terminus-ui/validators/src/validators.service.ts | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/terminus-ui/chart/src/amcharts.service.ts b/terminus-ui/chart/src/amcharts.service.ts index 0ab471388..d4b46859b 100644 --- a/terminus-ui/chart/src/amcharts.service.ts +++ b/terminus-ui/chart/src/amcharts.service.ts @@ -23,7 +23,7 @@ export const TS_AMCHARTS_TOKEN = new InjectionToken('amCharts') /** * Expose amCharts via a service */ -@Injectable() +@Injectable({ providedIn: 'root' }) export class TsAmChartsService { constructor( diff --git a/terminus-ui/chart/src/chart.component.md b/terminus-ui/chart/src/chart.component.md index cc84863b1..af3f7587d 100644 --- a/terminus-ui/chart/src/chart.component.md +++ b/terminus-ui/chart/src/chart.component.md @@ -22,7 +22,7 @@ > Note: Since the end-user of this library is the one with the actual license to use amCharts, we let the consumer pass in the library. -Create a factory function to inject the needed libraries: +Create a factory function to inject the needed libraries and plugins: ```typescript import { TS_AMCHARTS_TOKEN, TsAmChartsToken } from '@terminus/ui/chart'; diff --git a/terminus-ui/validators/src/validators.service.md b/terminus-ui/validators/src/validators.service.md index b4c205530..966dd7889 100644 --- a/terminus-ui/validators/src/validators.service.md +++ b/terminus-ui/validators/src/validators.service.md @@ -12,6 +12,7 @@ +NOTE: This service is provided as a singleton by defining the `providedIn` property as `root`. ## Basic usage diff --git a/terminus-ui/validators/src/validators.service.ts b/terminus-ui/validators/src/validators.service.ts index 16f69c522..01ca1b3d6 100644 --- a/terminus-ui/validators/src/validators.service.ts +++ b/terminus-ui/validators/src/validators.service.ts @@ -20,7 +20,7 @@ import { urlValidator } from './validators/url/url'; /** * Define a service that exposes custom form validators for use with reactive forms. */ -@Injectable() +@Injectable({ providedIn: 'root' }) export class TsValidatorsService { public creditCard = creditCardValidator; public domain = domainValidator;