Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChatChannel.isDisabled and disabled channel filtering key #3546

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

laevandus
Copy link
Contributor

@laevandus laevandus commented Jan 2, 2025

🔗 Issue Links

Resolves IOS-615

🎯 Goal

Handle disabled channel state in channel queries

📝 Summary

  • Add
    • ChatChannel.isDisabled
    • FilterKey.disabled for channel list queries

🛠 Implementation

Parse disabled state in channel list payloads and store it in the local DB (ChannelDTO.isDisabled). Expose it in ChatChannel and add filtering key for channel list queries.
disabled is a required value in backend responses.

🎨 Showcase

🧪 Manual Testing Notes

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@laevandus laevandus added 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK 🏗 Missing Feature Parity A feature that is not yet available on the iOS SDK. labels Jan 2, 2025
@laevandus laevandus requested a review from a team as a code owner January 2, 2025 11:58
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Jan 2, 2025

SDK Size

title develop branch diff status
StreamChat 7.03 MB 7.03 MB 0 KB 🟢
StreamChatUI 4.77 MB 4.77 MB 0 KB 🟢

@Stream-SDK-Bot
Copy link
Collaborator

SDK Performance

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 8.34 ms 16.6% 🔼 🟢
Duration 2.6 s 2.55 s 1.92% 🔼 🟢
Hitch time ratio 4 ms per s 3.28 ms per s 18.0% 🔼 🟢
Frame rate 75 fps 78.22 fps 4.29% 🔼 🟢
Number of hitches 1 1.0 0.0% 🟰 🟢

@laevandus laevandus changed the title Add ChatChannel.isDisabled and disabled channel filtering key [WIP] Add ChatChannel.isDisabled and disabled channel filtering key Jan 2, 2025
@laevandus laevandus changed the title [WIP] Add ChatChannel.isDisabled and disabled channel filtering key Add ChatChannel.isDisabled and disabled channel filtering key Jan 2, 2025
@laevandus laevandus merged commit be21a9e into develop Jan 2, 2025
14 checks passed
@laevandus laevandus deleted the feature/channel-disabled branch January 2, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏗 Missing Feature Parity A feature that is not yet available on the iOS SDK. 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants