Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-1094] Fix ChannelListController.synchronize not calling completion #1353

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

b-onc
Copy link
Contributor

@b-onc b-onc commented Aug 10, 2021

...when connected in offline mode

This happened because the EventObserver didn't get connected callback when we're already connected

…ne mode

This happened because the EventObserver didn't get `connected` callback when we're already connected
@b-onc b-onc added 🐞 Bug An issue or PR related to a bug 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK labels Aug 10, 2021
@b-onc b-onc requested a review from dmigach August 10, 2021 12:01
@codecov-commenter
Copy link

Codecov Report

Merging #1353 (37c2c9d) into main (08b7477) will decrease coverage by 0.01%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1353      +/-   ##
==========================================
- Coverage   90.75%   90.73%   -0.02%     
==========================================
  Files         224      224              
  Lines        9800     9805       +5     
==========================================
+ Hits         8894     8897       +3     
- Misses        906      908       +2     
Flag Coverage Δ
llc-tests 90.73% <20.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ChannelListController/ChannelListController.swift 82.45% <20.00%> (-1.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08b7477...37c2c9d. Read the comment docs.

@b-onc b-onc requested a review from tbarbugli August 10, 2021 17:02
Copy link
Member

@tbarbugli tbarbugli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbarbugli tbarbugli merged commit 120dd81 into main Aug 11, 2021
@tbarbugli tbarbugli deleted the cis-1094-channellist-sync branch August 11, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug An issue or PR related to a bug 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants