Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-1079] Fix CoreData misuse when creating Direct Messaging channels #1337

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

b-onc
Copy link
Contributor

@b-onc b-onc commented Aug 2, 2021

CoreData entities should be accessed from their own queues only.

Resolves #1336

@b-onc b-onc added 🐞 Bug An issue or PR related to a bug 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK labels Aug 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2021

Codecov Report

Merging #1337 (8cda2c5) into main (a5efc29) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1337      +/-   ##
==========================================
- Coverage   91.21%   91.16%   -0.06%     
==========================================
  Files         227      227              
  Lines        9767     9768       +1     
==========================================
- Hits         8909     8905       -4     
- Misses        858      863       +5     
Flag Coverage Δ
llc-tests 91.01% <100.00%> (+<0.01%) ⬆️
llc-tests-ios12 87.76% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...trollers/ChannelController/ChannelController.swift 92.24% <100.00%> (+0.01%) ⬆️
...eamChat/APIClient/Endpoints/Payloads/RawJSON.swift 83.33% <0.00%> (-11.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5efc29...8cda2c5. Read the comment docs.

Copy link
Contributor

@SagarSDagdu SagarSDagdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Copy link
Contributor

@DominikBucher12 DominikBucher12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛴🇮🇹

@b-onc b-onc merged commit 14bf8f6 into main Aug 2, 2021
@b-onc b-onc deleted the cis-1079-coredata-misuse branch August 2, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug An issue or PR related to a bug 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashes in Demo App - New Chat Creation - 4.0.0-beta.8
4 participants