[CIS-978] Fix deleted messages are visible in threads #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-onc
added
🐞 Bug
VojtaStavik
reviewed
Jun 30, 2021
Comment on lines
+136
to
+143
| /// Returns predicate with thread messages that should be shown in the thread. | ||
| static func threadRepliesPredicate(for messageId: MessageId) -> NSCompoundPredicate { |
There was a problem hiding this comment.
Since this logic is very similar to channel messages, should we find a way how to share this logic to prevent similar inconsistencies in the future?
There was a problem hiding this comment.
I actually copy/pasted some predicates (like deleted messages) so it makes sense to refactor these common predicates, i'll check/do this 👍
b-onc
force-pushed
the
cis-978-giphy-cancel-visible-in-thread
branch
from
55f84de to
16d3437
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't include proper predicates for reply fetching