[CIS-932] Fix composer overlapping last message #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtaStavik
approved these changes
Jun 22, 2021
| @@ -482,6 +482,8 @@ open class _ChatMessageListVC<ExtraData: ExtraDataTypes>: | |||
| _ channelController: _ChatChannelController<ExtraData>, | |||
| didChangeTypingMembers typingMembers: Set<_ChatChannelMember<ExtraData.User>> | |||
| ) { | |||
| guard channelController.areTypingEventsEnabled else { return } | |||
DominikBucher12
approved these changes
Jun 22, 2021
b-onc
force-pushed
the
cis-932-composer-overlap
branch
from
04d9b86 to
4507e1f
Compare
Codecov Report
@@ Coverage Diff @@
## main #1210 +/- ##
=======================================
Coverage 91.25% 91.25%
=======================================
Files 217 217
Lines 9277 9277
=======================================
Hits 8466 8466
Misses 811 811
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
b-onc
force-pushed
the
cis-932-composer-overlap
branch
from
4507e1f to
da6a8d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happened for channels with typing events disabled