[CIS-835] Introduce channel freeze/unfreeze #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-onc
added
🙏 Feature Request
b-onc
force-pushed
the
cis-835-channel-freeze
branch
from
18902f2 to
72f30e8
Compare
VojtaStavik
approved these changes
May 20, 2021
Comment on lines
+52
to
+59
| log.debug( | ||
| "Making URL request: \(endpoint.method.rawValue.uppercased()) \(endpoint.path)\n" | ||
| + "Body:\n\(urlRequest.httpBody?.debugPrettyPrintedJSON ?? "<Empty>")\n" | ||
| + "Query items:\n\(urlRequest.queryItems.prettyPrinted)" | ||
| ) | ||
|
|
Comment on lines
+180
to
+189
|
|
||
| static func freezeChannel(_ freeze: Bool, cid: ChannelId) -> Endpoint<EmptyResponse> { | ||
| .init( | ||
| path: "channels/" + cid.apiPath, | ||
| method: .patch, | ||
| queryItems: nil, | ||
| requiresConnectionId: false, | ||
| body: ["set": ["frozen": freeze]] | ||
| ) | ||
| } |
There was a problem hiding this comment.
This is actually a very nice and elegant workaround 👍
Codecov Report
@@ Coverage Diff @@
## main #1090 +/- ##
==========================================
- Coverage 91.71% 91.53% -0.18%
==========================================
Files 216 216
Lines 9145 9195 +50
==========================================
+ Hits 8387 8417 +30
- Misses 758 778 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
added 4 commits
May 20, 2021 15:07
Sample output:
---
2021-05-19 17:29:32.126 [DEBUG] [NSManagedObjectContext 0x6000037095f0] [APIClient.swift:52] [request(endpoint:completion:)] > Making URL request: POST sync
Body:
{
"last_sync_at" : "2021-05-19T15:28:20.066Z",
"channel_cids" : [
"messaging:201BD2D3-E",
.... //goes on
]
}
Query items:
<Empty>
---
or
---
2021-05-19 17:29:31.567 [DEBUG] [NSManagedObjectContext 0x60000370f740] [APIClient.swift:52] [request(endpoint:completion:)] > Making URL request: GET channels
Body:
<Empty>
Query items:
- payload={
"filter_conditions" : {
"members" : {
"$in" : [
"luke_skywalker"
]
}
},
"watch" : true,
"message_limit" : 25,
"limit" : 20
}
- connection_id=60a253bc-0a05-2761-0000-00000039c862
---
b-onc
force-pushed
the
cis-835-channel-freeze
branch
from
5c88449 to
bfba236
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually partial channel update, but we don't have the bandwidth to figure it out completely now. It's in our backlog and will be implemented fully soon.