From 4724bf9a8c604f2c1d1aa2cd8a33e28669b24866 Mon Sep 17 00:00:00 2001 From: Bahadir Oncel Date: Thu, 1 Apr 2021 17:13:12 +0300 Subject: [PATCH] Convert danger CHANGELOG check to message and include missing changelog entry for #945 --- CHANGELOG.md | 3 +++ Dangerfile | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 053c31ff9a6..0dd05081144 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). # Upcoming +### 🐞 Fixed +- Fix `ChannelController`s created with `createChannelWithId` and `createChannelWithMembers` functions not reporting their initial values [#945](https://github.com/GetStream/stream-chat-swift/pull/945) + ### 🔄 Changed - `Logger.assertationFailure` was renamed to `Logger.assertionFailure` [#935](https://github.com/GetStream/stream-chat-swift/pull/935) diff --git a/Dangerfile b/Dangerfile index d48dc72e973..c28d94f48ff 100644 --- a/Dangerfile +++ b/Dangerfile @@ -40,7 +40,7 @@ has_changelog_escape = has_meta_label || has_no_changelog_tag || has_skip_change # Add a CHANGELOG entry for app changes if !has_changelog_escape && !git.modified_files.include?("CHANGELOG.md") && has_app_changes - fail("Please include a CHANGELOG entry. \nYou can find it at [CHANGELOG.md](https://github.com/GetStream/stream-chat-swift/blob/main/CHANGELOG.md).") + message("There seems to be app changes but CHANGELOG wasn't modified.\nPlease include an entry if the PR includes user-facing changes.\nYou can find it at [CHANGELOG.md](https://github.com/GetStream/stream-chat-swift/blob/main/CHANGELOG.md).") end # Check all commits have correct format. Disable the length rule, since it's hardcoded