Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urgent: Including browser.full-bundle.min.js overwrites Image in browser global scope, breaks Facebook Pixel event tracking #553

Closed
tkrevh opened this issue Sep 30, 2020 · 2 comments · Fixed by #554

Comments

@tkrevh
Copy link

tkrevh commented Sep 30, 2020

Hello!

We're a paying customer and we've had issues with Facebook Pixel tracking for some months now. Finally today we were able to find the reason why FB Pixel tracking isn't working. It's because when loading your browser.full-bundle.min.js package, it overwrites the Image class on the browser window global scope. FB pixel tracks events by creating a new Image() and then setting it's src attribute to their tracking server URL; and with your bundle replacing the Image in global scope, this functionality is then broken.

Issue is in this file:
https://github.com/GetStream/stream-chat-react/blob/master/src/components/Gallery/Image.js

Can we please ask you to issue an urgent update to this and release a version where the global scope Image is not overwritten?

Thank you!

gz#6339

@tkrevh tkrevh changed the title Urgent: Including browser.full-bundle.min.js breaks Facebook Pixel event tracking Urgent: Including browser.full-bundle.min.js overwrites Image in browser global scope, breaks Facebook Pixel event tracking Sep 30, 2020
@mahboubii
Copy link
Contributor

@tkrevh fixed in v3.0.0

@tkrevh
Copy link
Author

tkrevh commented Sep 30, 2020

That's some serious speed 👍 Thank you very much 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants