feat: add group avatar #2556
Merged
feat: add group avatar #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2.3 kB (+0.2%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2556 +/- ##
==========================================
+ Coverage 83.18% 83.23% +0.04%
==========================================
Files 437 439 +2
Lines 9113 9142 +29
Branches 2232 2237 +5
==========================================
+ Hits 7581 7609 +28
- Misses 1204 1205 +1
Partials 328 328 ☔ View full report in Codecov by Sentry. |
oliverlaz
approved these changes
Nov 14, 2024
|
🎉 This PR is included in version 12.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Allow to display group avatar for group channels. The dichotomy however is between the
ChannelAvatarand a simpleAvatar.GroupAvataris just a component used byChannelAvatarin case there are more than 2 members in a channel. The componentAvatarstays the default for all the components in the SDK, however, the integrators can override it inChannelListandChannelHeaderwithChannelAvatar. This approach has been taken to avoid breakinch changes.Depends on GetStream/stream-chat-css#319
🎨 UI Changes