feat: add message edited timestamp #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myandrienko
requested review from
szuperaz and
MartinCupela
and removed request for
szuperaz
myandrienko
commented
Feb 28, 2024
| @@ -192,13 +192,29 @@ | |||
| .str-chat__message-metadata { | |||
| grid-area: metadata; | |||
| display: flex; | |||
| flex-wrap: wrap; | |||
There was a problem hiding this comment.
Adding wrap to the message metadata so that the "edited at ..." label can occupy the second line.
3 tasks
szuperaz
force-pushed
the
feat/message-edited-timestamp
branch
from
646dbd4 to
6265394
Compare
szuperaz
reviewed
Mar 4, 2024
| } | ||
| } | ||
|
|
||
| .str-chat__message-text--pointer-cursor { |
There was a problem hiding this comment.
@myandrienko I've added this here -> SDK's can apply this dynamically
There was a problem hiding this comment.
Angular logic for reference: https://github.com/GetStream/stream-chat-angular/pull/563/files#diff-1a38d0771c6ea73cc1bfd32b5699ffdc969cbcd65f0f99fef492517b2f201ed1R179-R183 - I know, I know that expression is a bit too complicated, but it handles the following cases:
- unsent message
- bounced message
- edited message
There was a problem hiding this comment.
Thanks, this is useful!
szuperaz
approved these changes
Mar 5, 2024
MartinCupela
approved these changes
Mar 5, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
# [4.8.0](v4.7.4...v4.8.0) (2024-03-05) ### Features * add message edited timestamp ([#275](#275)) ([d61a371](d61a371))
|
🎉 This PR is included in version 4.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
myandrienko
added a commit
to GetStream/stream-chat-react
that referenced
this pull request
Mar 7, 2024
### 🎯 Goal 🚂 GetStream/stream-chat-css#275 🚂 GetStream/stream-chat-js#1248 Adds a new collapsible section in message metadata that shows the last time message text was updated. Also, clearly labels edited messages. ### 🎨 UI Changes See GetStream/stream-chat-css#275 ### To-Do - [x] Bump LLC - [x] Bump styles - [x] Translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Adds styles for a new collapsible section in message status that shows the last time message text was updated.
🎨 UI Changes
Screen.Recording.2024-02-28.at.17.17.21.mov