Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to OpenAPI spec [meta-issue] #4394

Open
dafeder opened this issue Jan 27, 2025 · 2 comments
Open

Improvements to OpenAPI spec [meta-issue] #4394

dafeder opened this issue Jan 27, 2025 · 2 comments

Comments

@dafeder
Copy link
Member

dafeder commented Jan 27, 2025

This is a stub that needs to be broken out into a few specific tickets. Some possible improvements to our spec:

  1. Look at the output of https://pb33f.io/doctor/ report on our spec, identifiy examples that should be added to improve score and fix any actual errors
  2. Clearer separation of public API spec from private. Maybe show just public by default, or have a page on the admin side for the private/authenticated endpoints.
  3. Separate metastore and datastore public APIs into two separate sections. Build out datastore API docs with more robust narrative/explanations, and explanations for how to do groupings, orderings etc.
  4. Consolidate the metastore endpoints a bit more, it's a little confusing still how there are endpoints for datasets and then another set for schema as a parameter
@paul-m
Copy link
Contributor

paul-m commented Jan 27, 2025

If I feed the tool https://demo.getdkan.org/api/1

I get:

Specification cannot be used:

unable to parse OpenAPI specification: unable to parse the document, no index was created, check the syntax or version of the document.

@dafeder
Copy link
Member Author

dafeder commented Jan 28, 2025

Hmmm I copied and pasted the JSON and it worked. @paul-m if it's all minified it won't parse, you need to pretty-print it before copying.

Not sure why we don't pretty-print the /api/1 endpoint on our end though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants