-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config option in metastore settings to stop forcing redirect #4381
Open
zedmonds96
wants to merge
20
commits into
2.x
Choose a base branch
from
DKAN-4326
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+258
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to add a test for this, moving back to draft. |
Updated the form structure to satisfy codeclimate now and in the future. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4326
Describe your changes
Added a configuration option in metastore settings. If checked, the user will be redirected to the datasets view when creating/editing a dataset. If unchecked, the user will remain on the node page for the dataset instead of the redirect.
redirect_to_dataset
tometastore.settings.yml
.redirect_to_dataset
tometastore.schema.yml
.redirect_to_datasets
checkbox to the metastore settings form inDkanDataSettingsForm.php
metastore_admin_form_submit()
inmetastore_admin.module
to get the checkbox value on submission to determine redirect behavior.metastore_update_8010()
tometastore.install
to set the default value of the config.RedirectToDatasetsTest.php
QA Steps
Checklist before requesting review
If any of these are left unchecked, please provide an explanation