Skip to content

Commit 454b918

Browse files
committed
Fix comma pedal grinding noise when braking
commit 5dd7fb3dbe01c8854eb4784080cf7108fc970cb9 Date: Wed Dec 19 19:34:55 2018 -0500 Revert "BRAKE_STOPPING_TARGET reduced to 0.1 from 0.25" This reverts commit b0d75c5. commit f5cec844471cd4eb650450d88e6118ff818d5edb Date: Wed Dec 19 19:34:16 2018 -0500 Revert "BRAKE_STOPPING_TARGET to 0.0" This reverts commit 7a6b3a67826dd1fd5b942b06eb7c1d15b0f3c23a. commit 1e07b857438aaf983e36f45aa3653ab61aadc17f Date: Wed Dec 19 00:38:09 2018 -0500 Update carstate.py commit f6b3ba0696f5192167780579a9daa05a39bd30e2 Date: Wed Dec 19 00:33:54 2018 -0500 Pedal grind further Code cleanup commit 0afbcd38396ffd863d963194dda8ddb8e9f2bf02 Date: Wed Dec 19 00:16:15 2018 -0500 Pedal Grinding further code cleanup commit 33b4ce0e38441463846d593861183f96a154e11e Date: Tue Dec 18 16:48:03 2018 -0500 Grinding noise code cleanup commit f6edcfacd22fe503330adcd0bef2b9aa9a742838 Date: Tue Dec 18 16:19:25 2018 -0500 Fix Syntax error commit 2a74863cf4e6d93e3b390d41fa427243f28ebdfa Date: Tue Dec 18 16:12:46 2018 -0500 Pedal noise mitigation v1 commit 7a6b3a67826dd1fd5b942b06eb7c1d15b0f3c23a Date: Tue Dec 18 10:53:11 2018 -0500 BRAKE_STOPPING_TARGET to 0.0
1 parent 9ecd304 commit 454b918

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

selfdrive/car/honda/carstate.py

+7-1
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,6 @@ def update(self, cp, cp_cam):
278278

279279
self.steer_torque_driver = cp.vl["STEER_STATUS"]['STEER_TORQUE_SENSOR']
280280
self.steer_override = abs(self.steer_torque_driver) > STEER_THRESHOLD[self.CP.carFingerprint]
281-
282281
self.brake_switch = cp.vl["POWERTRAIN_DATA"]['BRAKE_SWITCH']
283282

284283
if self.CP.radarOffCan:
@@ -305,13 +304,20 @@ def update(self, cp, cp_cam):
305304
self.brake_pressed = cp.vl["POWERTRAIN_DATA"]['BRAKE_PRESSED'] or \
306305
(self.brake_switch and self.brake_switch_prev and \
307306
cp.ts["POWERTRAIN_DATA"]['BRAKE_SWITCH'] != self.brake_switch_ts)
307+
308308
self.brake_switch_prev = self.brake_switch
309309
self.brake_switch_ts = cp.ts["POWERTRAIN_DATA"]['BRAKE_SWITCH']
310310

311311
self.user_brake = cp.vl["VSA_STATUS"]['USER_BRAKE']
312312
self.pcm_acc_status = cp.vl["POWERTRAIN_DATA"]['ACC_STATUS']
313313
self.hud_lead = cp.vl["ACC_HUD"]['HUD_LEAD']
314314

315+
# gets rid of Pedal Grinding noise
316+
if self.user_brake > 0.05 or self.brake_pressed:
317+
self.brake_pressed = 1
318+
else:
319+
self.brake_pressed = 0
320+
315321
# when user presses distance button on steering wheel
316322
if self.cruise_setting == 3:
317323
if cp.vl["SCM_BUTTONS"]["CRUISE_SETTING"] == 0:

selfdrive/controls/lib/longcontrol.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
STOPPING_BRAKE_RATE = 0.2 # brake_travel/s while trying to stop
1414
STARTING_BRAKE_RATE = 0.8 # brake_travel/s while releasing on restart
15-
BRAKE_STOPPING_TARGET = 0.1 # apply at least this amount of brake to maintain the vehicle stationary
15+
BRAKE_STOPPING_TARGET = 0.25 # apply at least this amount of brake to maintain the vehicle stationary
1616

1717
_MAX_SPEED_ERROR_BP = [0., 30.] # speed breakpoints
1818
_MAX_SPEED_ERROR_V = [1.5, .8] # max positive v_pid error VS actual speed; this avoids controls windup due to slow pedal resp

0 commit comments

Comments
 (0)