Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change QR lib #7

Open
Gerifield opened this issue Oct 6, 2024 · 3 comments
Open

Change QR lib #7

Gerifield opened this issue Oct 6, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@Gerifield
Copy link
Owner

Change the QR gen. lib to https://github.com/yeqown/go-qrcode
Which has a broader feature support, like adding an image to the code.

@Gerifield Gerifield added the enhancement New feature or request label Oct 6, 2024
@Gerifield
Copy link
Owner Author

As an option the AFR logo could be added: https://www.mnb.hu/letoltes/mnb-afr-qvik-brandbook-2024.pdf

@Gerifield
Copy link
Owner Author

Gerifield commented Oct 15, 2024

The lib needs to be able to do encoding supporting segments/variable encoding.
The string content contains line feeds which do not count as alphanumeric so by default the encoding will be binary, but that results in a version 14 (a bit bigger) QR code, not the standard ver. 13 as it should be, for the max. allowed content size.

With variable/segment encoding the QR size should be smaller and should fit in the ver. 13.
(But I highlty doubt the applications do validations on this.)

@Gerifield
Copy link
Owner Author

https://github.com/piglig/go-qr/ supports segments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant