Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewing for JOSS: Update LICENSE #279

Closed
pritamd47 opened this issue Nov 8, 2024 · 2 comments · Fixed by #341
Closed

Reviewing for JOSS: Update LICENSE #279

pritamd47 opened this issue Nov 8, 2024 · 2 comments · Fixed by #341
Assignees

Comments

@pritamd47
Copy link

Hi. I am a reviewer for your submission at JOSS at @openjournals/joss-reviews#743. As per the recommendation of the journal's reviewing guidelines, I will be opening issues and relevant PRs if needed throughout the review. Please don't hesitate to reach out for clarification or help!

I notice that the LICENSE file has some additional text at the end that could be removed to make the language of the license as per the OSI approved GNU license. I think the LICENSE file should only have the lines until "END OF TERMS AND CONDITIONS". The lines under it should be added to each file of the code. See the end of the document at https://opensource.org/license/agpl-v3 for more details.

@LukeParky
Copy link
Member

Hi @pritamd47, thank you for suggesting this. A fix is available in the PR #341. Could you please check that it matches your expectations for this issue?

@LukeParky
Copy link
Member

Note: This issue is related to the JOSS submission openjournals/joss-reviews#7433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants