Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking issue] gwb-grid improvements #526

Open
MFraters opened this issue Jan 23, 2024 · 3 comments
Open

[Tracking issue] gwb-grid improvements #526

MFraters opened this issue Jan 23, 2024 · 3 comments
Labels
hackathon-2024 A hackathon 2024 project

Comments

@MFraters
Copy link
Member

The following are subprojects to improve gwb-grid:

  1. Improve documentation of gwb-grid: Currently there is a short description in the manual here: https://gwb.readthedocs.io/en/latest/user_manual/how_to_use_the_applications/gwb-grid_app.html which can be expanded, but this page: https://gwb.readthedocs.io/en/latest/GWB_parameter_listings/world_builder_file/index.html should also be filled or removed.
  2. Improve testing of gwb-grid grids: Currently only cartesian and chunk are tested, but there is also a sphere and an anullus.
  3. The gwb-grid should be added to the coverage result: maybe as a separate category, or just lump it in with the rest
  4. Better parallelization: gwb-grid currently only has a very simple parallezation scheme. Some kind of job system would be better. (@tjhei?)
  5. Add vti output support: this is useful for online visualization in point 7 (@tjhei)
  6. Add netcdf output support (@tjhei)
  7. Implement online visualization: through glance (https://pvw.kitware.com/glance/) (@tjhei)
@tjhei
Copy link
Contributor

tjhei commented Feb 16, 2024

Conversation about better parallelization:

@tjhei
Copy link
Contributor

tjhei commented Feb 19, 2024

Do you have an example where the current parallel scheduling is not ideal? I could not reproduce based on your description.

@MFraters
Copy link
Member Author

It mostly shows up at larger models. For example, if you double the resolution of in cookbooks/3d_cartesian_curved_subduction/3d_cartesian_curved_subduction.grid and then run ./bin/gwb-grid -j 6 ../cookbooks/3d_cartesian_curved_subduction/3d_cartesian_curved_subduction.wb ../cookbooks/3d_cartesian_curved_subduction/3d_cartesian_curved_subduction.grid (in release mode), you can see that the first few are done very quickly. The higher resolution, the more the problem creeps up. Doubling the resolution again will make it very clear.

But I noticed that when doing the second doubling, the fact that the creating the grid and the writing of the paraview file are not parallel, is costing way more time at that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hackathon-2024 A hackathon 2024 project
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants