Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the tolerance for radius calculation #427

Open
alarshi opened this issue May 16, 2022 · 1 comment
Open

Relax the tolerance for radius calculation #427

alarshi opened this issue May 16, 2022 · 1 comment
Labels
small project A small, well defined, project to work on

Comments

@alarshi
Copy link
Contributor

alarshi commented May 16, 2022

While writing a test for the WorldbuilderApp, I got an error at ln 288 in source/world.cc as
Inconsistent input. Please check whether the radius in the sperhical coordiantes is consistent with the radius of the planet as defined in the program that uses the Geodynamic World Builder. Depth = 0, radius = 6.371e+06, point = 5.77211e+06 -2.69158e+06 -166773, radius-point.norm() = -9.31323e-10
This residual radius norm is quite low and this error was circumvented using the option -ldcc by @MFraters . Maybe we can add this option as default.

@MFraters
Copy link
Member

The tester now has -ldcc on by default, which should solve the problem I think. Let me know if you think it should be the default in all cases. My worry with that is that it becomes kind of useless, because you would need to turn this option, which no one really now about, manually on. We could improve the message to tell about a way to overwrite this assert.

@MFraters MFraters added the small project A small, well defined, project to work on label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small project A small, well defined, project to work on
Projects
None yet
Development

No branches or pull requests

2 participants