Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mass conservative ridge coordinates which where interally not converted to radians. #352

Conversation

MFraters
Copy link
Member

I found an issue with the mass conservative plugin where the ridge coordinates which where internally not converted to radians.

@mibillen

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #352 (7c84044) into main (e73f0e0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #352   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files          76       76           
  Lines        4428     4434    +6     
=======================================
+ Hits         4377     4383    +6     
  Misses         51       51           
Impacted Files Coverage Δ
...ucting_plate_models/temperature/mass_conserving.cc 97.20% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e73f0e0...7c84044. Read the comment docs.

@MFraters
Copy link
Member Author

I now see why the tester didn't pick this up, there is test for the spherical case. I will add that to this pull request. The issue does not affect the Cartesian case, only the spherical case.

@github-actions
Copy link

github-actions bot commented Oct 27, 2021

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.216 ± 0.002 (s=368) 1.216 ± 0.004 (s=375) -0.1% .. +0.1%
Slab interpolation curved simple none 1.568 ± 0.025 (s=263) 1.567 ± 0.022 (s=314) -0.5% .. +0.4%
Spherical slab interpolation simple none 1.413 ± 0.005 (s=310) 1.414 ± 0.006 (s=329) -0.0% .. +0.2%
Slab interpolation simple curved CMS 1.791 ± 0.062 (s=249) 1.788 ± 0.060 (s=257) -1.2% .. +0.8%
Spherical slab interpolation simple CMS 3.016 ± 0.047 (s=153) 3.000 ± 0.045 (s=149) -1.1% .. +0.1%
Spherical fault interpolation simple none 1.679 ± 0.071 (s=265) 1.684 ± 0.073 (s=273) -0.9% .. +1.6%

@MFraters MFraters force-pushed the fix_max_conservative_ridge_deg_to_rad branch from 939f576 to 7c84044 Compare October 29, 2021 01:16
@MFraters
Copy link
Member Author

I have updated this after the merging of #354, and the results look good. So both this pull request is ready to be merged and think this is going to close issue #350 as well.

@MFraters MFraters merged commit cef2812 into GeodynamicWorldBuilder:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant