Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/is savable #856

Merged
merged 7 commits into from
Oct 13, 2023
Merged

Fix/is savable #856

merged 7 commits into from
Oct 13, 2023

Conversation

BotellaA
Copy link
Member

No description provided.

github-actions[bot]
github-actions bot reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 41. Check the log or trigger a new build to see more.

bindings/python/src/image/io/raster_image.cpp Show resolved Hide resolved
bindings/python/src/mesh/io/edged_curve.cpp Show resolved Hide resolved
bindings/python/src/mesh/io/hybrid_solid.cpp Show resolved Hide resolved
bindings/python/src/mesh/io/point_set.cpp Show resolved Hide resolved
bindings/python/src/mesh/io/polygonal_surface.cpp Show resolved Hide resolved
include/geode/mesh/io/polygonal_surface_output.h Show resolved Hide resolved
include/geode/mesh/io/polyhedral_solid_output.h Show resolved Hide resolved
include/geode/mesh/io/regular_grid_output.h Show resolved Hide resolved
include/geode/mesh/io/tetrahedral_solid_output.h Show resolved Hide resolved
include/geode/mesh/io/triangulated_surface_output.h Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/geode/image/io/raster_image_output.cpp Show resolved Hide resolved
src/geode/mesh/io/edged_curve_output.cpp Show resolved Hide resolved
src/geode/mesh/io/graph_output.cpp Show resolved Hide resolved
src/geode/mesh/io/hybrid_solid_output.cpp Show resolved Hide resolved
src/geode/mesh/io/point_set_output.cpp Show resolved Hide resolved
src/geode/mesh/io/tetrahedral_solid_output.cpp Show resolved Hide resolved
src/geode/mesh/io/triangulated_surface_output.cpp Show resolved Hide resolved
src/geode/mesh/io/vertex_set_output.cpp Show resolved Hide resolved
src/geode/model/representation/io/brep_output.cpp Show resolved Hide resolved
src/geode/model/representation/io/section_output.cpp Show resolved Hide resolved
@BotellaA BotellaA merged commit 05d57b9 into next Oct 13, 2023
19 checks passed
@BotellaA BotellaA deleted the fix/is-savable branch October 13, 2023 14:57
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

🎉 This PR is included in version 14.9.1-rc.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 14.9.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@JulienChampagnol JulienChampagnol JulienChampagnol approved these changes

@MelchiorSchuh MelchiorSchuh MelchiorSchuh approved these changes

@panquez panquez Awaiting requested review from panquez

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BotellaA @MelchiorSchuh @JulienChampagnol