-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Class for Conditioned Spatial Random Fields #130
Conversation
…variance; doc update
@LSchueler this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, the SRF
class is looking soo much nicer now!
Really nice work!
I suggest to import gstools.field.base.Field
to gstools.field
. The import in one of the examples looks a but ugly.
I just made a few small remarks in the code. I think after you have addressed we are ready to go!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-) Found another typo ;-)
But anyway, here is a big thumbs up!
Closes: #128, #126
This PR adds a new class for conditioned random fields
CondSRF
.This class replaces the conditioning feature of the SRF class, which was limited to Ordinary and Simple kriging.
CondSRF
behaves similar to theSRF
class, but instead of a covariance model, it takes a kriging class as input. With this kriging class, all conditioning related settings are defined.During refactoring the
RandMeth
class, a switch to select the sampling strategy was added.Note
This change breaks backward compatibility, since conditioned random fields are no longer provided by the
SRF
class.