Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible room size #89

Closed
leny opened this issue Jan 26, 2021 · 5 comments · Fixed by #149
Closed

Flexible room size #89

leny opened this issue Jan 26, 2021 · 5 comments · Fixed by #149
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@leny
Copy link

leny commented Jan 26, 2021

Hi, thanks for this great project!

I will try to see if I can tweak that in the code, but maybe you can tell me if it's possible to implement that feature: at the moment, we can only create a room for a specific amount of player.
It could be great to have more feedback on the "waiting modal", to see how many (and maybe the nicknames) of the players already connected, with a button to start the game at any point.

Thanks in advance, I will make a pull request if I can. :)

@BilelJegham BilelJegham added the enhancement New feature or request label Jan 26, 2021
@BilelJegham
Copy link
Member

Hi, great idea.

The roomSize is used to end the room.
But I think you can add a step in the room definition. src/components/widgets/dialog/DialogRoom.vue

@wlanowski
Copy link
Contributor

If Flexible room size is working, idea:
Creating loby with running rooms with possibility to join and to kick players. Optional password protecting of rooms.

@supersational
Copy link

Just a 👍 to this, I almost gave up trying to get 8 people to join a game, managed after a few attempts and the experience was then flawless so thanks to the devs!

The issue was it wasn't easy to see who we were waiting for, so a list of names of players who've joined would be super helpful.. In the confusion I think some people may have joined twice which then prevented others from joining.

Another reason this would be helpful is that a lot of people starting/quitting games can quickly burn through your Maps API free quota, since I think each start of a new game instantiates a new map?

@leny
Copy link
Author

leny commented Mar 18, 2021

Hi, I finally kinda gave up on this... I started digging into the codebase, but I never really work with VueJS before and I don't have the time right now to do the switch.
Moreover, one of my student (I also teach web dev in a bootcamp-style school) suggest the idea to make our own clone of Geoguessr as a pedagogic project.

So, yes, I fixed the issue... on "my" version of the game, this time in react.

Regarding the flexible room size, the idea is really easy: creator of the room don't fix a size, see the name of players joining in a "lobby" screen, and then can start the game at any moment.

@BilelJegham BilelJegham added this to the 0.6.0 milestone Mar 19, 2021
@BilelJegham
Copy link
Member

BilelJegham commented Mar 19, 2021

I regret not being able to help you. 😢
I will take a look your implementation to had it in Geoguess 😉

This was referenced Mar 28, 2021
@BilelJegham BilelJegham self-assigned this Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants