Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autostage_limit attribute in staging controller is not read/writable #2

Closed
Ernesto-Alvarez opened this issue May 9, 2019 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@Ernesto-Alvarez
Copy link

While configuring the autopilot, I noticed that, contrary to the documentation, the StagingController.autostage_limit does not change MJ2's configuration.

To reproduce:
Put a vehicle on the launch pad.
Fill the options->stop at stage# field with something characteristic (6 in the example)
Run the following program:

import krpc

conn = krpc.connect(name="Launch into orbit")

sc = conn.space_center
mj = conn.mech_jeb
ascent = mj.ascent_autopilot
st = ascent.staging_controller
st.autostage_limit
6
st.autostage_limit = 1
st.autostage_limit
6

The program reports the correct value for the field but ignores the assignment. The field does not change in MJ2's window in KSP. The attribute remains unchanged after assignment, but changes if new value is punched in via MJ2 window.

@Genhis
Copy link
Owner

Genhis commented May 9, 2019

Hi,
I will look into it this weekend and release a fix by Sunday

@Ernesto-Alvarez
Copy link
Author

Thanks!
I really like your plugin. It's great for rocket testing.
Great work!

@Genhis Genhis added the bug Something isn't working label May 11, 2019
@Genhis Genhis added this to the 0.4.1 milestone May 11, 2019
@Genhis Genhis closed this as completed in 8ae4bd2 May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants