Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to set SmartASS surface vel only sets yaw #15

Closed
TheTimgor opened this issue Jan 26, 2021 · 1 comment
Closed

Attempting to set SmartASS surface vel only sets yaw #15

TheTimgor opened this issue Jan 26, 2021 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@TheTimgor
Copy link

Setting surface retrograde/prograde values with Smart ASS only updates yaw values in game

Code snippet to reproduce

import krpc

conn = krpc.connect(name="plz work")
smart_ass = conn.mech_jeb.smart_ass

smart_ass.autopilot_mode = smart_ass.autopilot_mode.surface_retrograde  # or prograde
smart_ass.surface_vel_yaw = 45
smart_ass.force_roll = True
smart_ass.surface_vel_roll = 45
smart_ass.surface_vel_pitch = 45
smart_ass.update(False)

print(smart_ass.surface_vel_yaw, smart_ass.surface_vel_roll, smart_ass.surface_vel_pitch)

Expected behavior
Autopilot switches to surface retrograde mode with roll, pitch, and yaw set to 45 degrees.

Actual behavior

Only yaw is set. The print statement outputs 45.0 45.0 45.0 so the values are changed (nothing is resetting them), so presumably they're just not being sent to mechjeb.

Version details
If it's important, the game has Realism Overhaul installed and I'm on Ubuntu 19.10

kRPC.MechJeb: v0.5.1

Kerbal Space Program: 1.8.1
kRPC: 0.4.8
MechJeb2: 2.9.2.0

@Genhis Genhis added the bug Something isn't working label Jan 26, 2021
@Genhis
Copy link
Owner

Genhis commented Jan 26, 2021

Thank you for reporting the issue. Currently, surface_vel_roll and surface_vel_pitch behave the same as surface_roll and surface_pitch (but they shouldn't). I will release a fix tomorrow.

@Genhis Genhis added this to the 0.6.1 milestone Jan 27, 2021
@Genhis Genhis closed this as completed in 7005400 Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants