Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Mutations: proportion filter on grid view #131

Closed
JonasKellerer opened this issue Apr 9, 2024 · 0 comments · Fixed by #134
Closed

Fix: Mutations: proportion filter on grid view #131

JonasKellerer opened this issue Apr 9, 2024 · 0 comments · Fixed by #134
Assignees
Labels
components Regarding the components

Comments

@JonasKellerer
Copy link
Collaborator

#127 refactored the mutations component but introduced an unwanted behavior:
On the grid view, the proportion selector should filter out only those mutations, where non of the mutations on a given position are above/below the threshold. If only one is above, the others should still show.

Fix this and introduce a test, so this does not occur again.

Example of the issue:
Here only one mutation shows at 2683
grafik

With a lower threshold two are shown
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
components Regarding the components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant