Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: type safe checking for validation and caching of ndjson-file-emptiness #494

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

Taepper
Copy link
Collaborator

@Taepper Taepper commented Jun 18, 2024

Summary

refactor: type safe checking for validation and caching of ndjson-file-emptiness

PR Checklist

- [ ] All necessary documentation has been adapted or there is an issue to do so.
- [ ] The implemented feature is covered by an appropriate test.

Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Taepper Taepper merged commit 5e3041e into main Jun 19, 2024
9 checks passed
@Taepper Taepper deleted the remember-emptiness branch June 19, 2024 07:01
Taepper added a commit that referenced this pull request Jun 19, 2024
 that release actually fixed bugs in integration
Taepper added a commit that referenced this pull request Jun 19, 2024
that release actually fixed bugs in integration
davidgicev pushed a commit that referenced this pull request Aug 4, 2024
davidgicev pushed a commit that referenced this pull request Aug 4, 2024
that release actually fixed bugs in integration
@github-actions github-actions bot mentioned this pull request Aug 6, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants