Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ndjsonInputFile option and unify code paths #419

Closed
Tracked by #387
Taepper opened this issue May 13, 2024 · 1 comment
Closed
Tracked by #387

Remove ndjsonInputFile option and unify code paths #419

Taepper opened this issue May 13, 2024 · 1 comment

Comments

@Taepper
Copy link
Collaborator

Taepper commented May 13, 2024

The current abstraction for input files feels quite off.

It does not really make sense that there is a metadataInputFilename and ndjsonInputFilename competing, one of which describes format, the other the type of data. These should be unified with an automatic detection of the code paths to choose.

That sequences can only be provided externally in .fasta files, when specifying a metadataInputFilename, is also very unintuitive
@Taepper Taepper mentioned this issue May 13, 2024
Open
10 tasks
@fengelniederhammer
Copy link
Contributor

Irrelevant due to #562

@fengelniederhammer fengelniederhammer closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Taepper @fengelniederhammer