Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate input data #129

Open
8 tasks
Tracked by #387 ...
fengelniederhammer opened this issue Jun 15, 2023 · 6 comments
Open
8 tasks
Tracked by #387 ...

Validate input data #129

fengelniederhammer opened this issue Jun 15, 2023 · 6 comments
Assignees
Labels
LAPIS Tasks/PR related to LAPIS
Milestone

Comments

@JonasKellerer
Copy link
Contributor

"primary key exists in metadata, is unique and every metadata primary key exists in sequences." exists already

@fengelniederhammer
Copy link
Contributor Author

Mind #215 (comment) and improve log messages

@fengelniederhammer
Copy link
Contributor Author

Try to reproduce #361 and fix it.

@Taepper
Copy link
Collaborator

Taepper commented May 17, 2024

Also: Unit tests that execute the preprocessing in both paths

@corneliusroemer
Copy link
Contributor

Motivated by the bug hunt related to loculus-project/loculus#2667

Extra validation ideas:

  • run a self test after import, running a bunch of queries/assertions
    • if downloading all sequences, get correct number of sequences
    • if downloading all sequences, don't get duplicate sequence ids
    • ...

@Taepper
Copy link
Collaborator

Taepper commented Sep 18, 2024

After #458 a lot of this should already be implemented.

We will add separate issues to verify and that check that proper error messages are returned accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LAPIS Tasks/PR related to LAPIS
Projects
None yet
Development

No branches or pull requests

4 participants