Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skyscraper doesn't build with XDG support #116

Closed
deadendpl opened this issue Jan 11, 2025 · 1 comment · Fixed by #117
Closed

Skyscraper doesn't build with XDG support #116

deadendpl opened this issue Jan 11, 2025 · 1 comment · Fixed by #117

Comments

@deadendpl
Copy link

Describe the bug

I uncomment the line with #DEFINES+=XDG in skyscraper.pro.
When I update Skyscraper, it seems that the skyscraper.pro file gets overwritten and has #DEFINES+=XDG commented, thus Skyscraper doesn't get built with XDG support.

To Reproduce

  1. Run the installation instructions from the guide.
  2. See if the XDG support is enabled in skyscraper.pro file, and enable it if it isn't.
  3. Reinstall Skyscraper using update_skyscraper.sh to see that it didn't build with XDG support by running Skyscraper --version.
  4. Reinstall Skyscraper using update_skyscraper.sh, but as soon as compiling starts, cancel it.
  5. Look into the skyscraper.pro file again, to see that XDG support is disabled.

Expected behavior

After 2nd step of reproduction, Skyscraper should build with XDG support enabled.

Additional context

I saw that the 3.14.0 tarball has the skyscraper.pro file that has XDG support disabled, it may overwrite the current skyscraper.pro file that could have it enabled.

@Gemba
Copy link
Owner

Gemba commented Jan 16, 2025

Yep. That one escaped me. Thanks for taking your time to elaborate the bug+description. Should be ok now.
I have also updated the README to detail how to get a XDG build with the update script: https://github.com/Gemba/skyscraper?tab=readme-ov-file#download-compile-and-install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants