From 6fb947da8ae0ad38500a9fbdc1d4c2c40a74666b Mon Sep 17 00:00:00 2001 From: enagorny Date: Wed, 14 Sep 2022 14:00:31 +0300 Subject: [PATCH 1/2] fix: warning on RN v0.65+ --- src/core/color-mode/hooks.tsx | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/core/color-mode/hooks.tsx b/src/core/color-mode/hooks.tsx index 8e7302a02..7fe8f6c92 100644 --- a/src/core/color-mode/hooks.tsx +++ b/src/core/color-mode/hooks.tsx @@ -31,8 +31,18 @@ export const useAppState = () => { () => ({ getCurrentValue: () => AppState.currentState, subscribe: (callback: () => void) => { - AppState.addEventListener('change', callback); - return () => AppState.removeEventListener('change', callback); + const subsription = AppState.addEventListener('change', callback); + // return () => AppState.removeEventListener('change', callback); + return () => { + if (AppState.removeEventListener) { + // React Native < 0.65 + AppState.removeEventListener('change', callback); + } else { + // React Native >= 0.65 + // @ts-ignore:next-line ignoring ts error as devDependency contains "@types/react-native" < 0.65 + subsription.remove(); + } + }; }, }), [] From 438238806a7ff87cd0aa5c85772d5110f6a93eae Mon Sep 17 00:00:00 2001 From: Rohit Singh <36300815+rayan1810@users.noreply.github.com> Date: Fri, 21 Oct 2022 20:33:33 +0530 Subject: [PATCH 2/2] Update src/core/color-mode/hooks.tsx Removing comment. Co-authored-by: Kevin Dice --- src/core/color-mode/hooks.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/core/color-mode/hooks.tsx b/src/core/color-mode/hooks.tsx index 7fe8f6c92..1c22ea45b 100644 --- a/src/core/color-mode/hooks.tsx +++ b/src/core/color-mode/hooks.tsx @@ -32,7 +32,6 @@ export const useAppState = () => { getCurrentValue: () => AppState.currentState, subscribe: (callback: () => void) => { const subsription = AppState.addEventListener('change', callback); - // return () => AppState.removeEventListener('change', callback); return () => { if (AppState.removeEventListener) { // React Native < 0.65